8000 Speedy trial activation parameters for Taproot by achow101 · Pull Request #21686 · bitcoin/bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Speedy trial activation parameters for Taproot #21686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2021
Merged

Speedy trial activation parameters for Taproot #21686

merged 1 commit into from
Apr 15, 2021

Conversation

achow101
Copy link
Member

Adds the activation parameters for taproot as specified in bitcoin/bips#1104

luke-jr
luke-jr suggested changes Apr 15, 2021
View reviewed changes
Copy link
Member
@luke-jr luke-jr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Concept NACK. Devs have no authority to make consensus changes against community consensus.

@JeremyRubin
Copy link
Contributor
JeremyRubin commented Apr 15, 2021 •
edited
Loading

ACK 7e69b2f these match the BIP

@ajtowns
Copy link
Contributor
ajtowns commented Apr 15, 2021

Maybe include the (expected) dates as comments? That's been done in the past, see #8937. ACK otherwise.

@achow101 achow101 force-pushed the taproot-mtp-st-params branch from 7e69b2f to 96608b1 Compare April 15, 2021 02:53
@achow101
Copy link
Member Author

Maybe include the (expected) dates as comments? That's been done in the past, see #8937. ACK otherwise.

Done.

@achow101 achow101 force-pushed the taproot-mtp-st-params branch from 96608b1 to f979b32 Compare April 15, 2021 02:54
@JeremyRubin
Copy link
Contributor

reack f979b32

@gmaxwell
Copy link
Contributor

utACK f979b32

As per: #21377 (comment)

@ajtowns
Copy link
Contributor
ajtowns commented Apr 15, 2021

ACK f979b32

@ajtowns
Copy link
Contributor
ajtowns commented Apr 15, 2021

Concept NACK. Devs have no authority to make consensus changes against community consensus.

Note that luke-jr is on the record as committing to NACK lot=false proposals in general, in accordance with his list post on the topic:

11:08 < luke-jr> personally I plan to NACK any LOT=False; but I doubt I would need to at this point (devs pushing against LOT=True seem to be off shed-painting other bad ideas now)
12:42 < hashcash> make a PR for core with LOT=false
12:42 < luke-jr> hashcash: I will NACK it

@instagibbs
Copy link
Member

"needs backport" (obviously)

@instagibbs
Copy link
Member

ACK f979b32
in it matches the BIP draft

@clarkmoody
Copy link

ACK f979b32

@Sjors
Copy link
Member
Sjors commented Apr 15, 2021

ACK f979b32

Fancy PGP signature

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256

ACK f979b32
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE7ZvfetalXiMuhFJCV/+b28wwEAkFAmB37eMACgkQV/+b28ww
EAn+cw/+KXnEpGiRXlWJlUSGxyASQn9mF5iJR46E50yqOJdRaEfGDOnViRfXluZY
xzgehN5rd9/HcXABD3lvRPQUEnI0NLtVdue8EcWLeRfyaNV5Tu/hYXHSw1DtO1tw
ne9WR62+t71fVsVU1jHWL8fEr4wcwBnvfVBAw8hN8WrF6MICuTdIYTge5F3DLtAj
L5Bj8fDbwLxmEtuJBFTXMq2yHzObzvOh47cI9pKO+ylQYZjVF03iybPFl2woBxV3
+cWZQ4SkBzMW0hCWAeHLbWpkrnrwuO+Bb8hWcVeD2MdMvUDpJtn9cOiRajb+LviW
mrcxzOZU4/asEXgUa6XZZrrFeRfWq4XisEm7w+PgUNJC0z6xCBu+PLJyqNcC4xIR
2BGr/VYxidrMDNMbh/YNX6HfRecXfaOxzgVpnb0hwZDr6bQrNgYU4wLBnTYcUTiE
iMtnvd6uBu/KjGsDBkRPKvxBvKQmHSxoleEQmmPX3bYfy7e++YKMApe++u4dWirk
aadHx2Us9PVpIdCH/TKDhxKuYFcgI0EmaVUkALRa/ClHp9WBpdlCzqivB8TSR14F
kKKd88xMhhNnynJSW4NYhflDQ7FV5ljMQR9xEnQ5UWN2mxFYPu3bw56IHTgGcT8c
6kRYQSo/FVceGI4Sg1mukZZMVaMlkvo+MFejDjuAxn2+Ig07C0Q=
=pEwh
-----END PGP SIGNATURE-----

jonatack
jonatack approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member
@jonatack jonatack left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK f979b32 verified with the BIP draft

>> Time.at(1619222400).to_time.utc
=> 2021-04-24 00:00:00 UTC
>> Time.at(1628640000).to_time.utc
=> 2021-08-11 00:00:00 UTC

@maflcko maflcko merged commit 7cb0bcb into bitcoin:master Apr 15, 2021
@jnewbery
Copy link
Contributor

ACK f979b32

achow101 added a commit to achow101/bitcoin that referenced this pull request Apr 15, 2021
@achow101
Add mainnet and testnet taproot activation params
37c255c 
Github-Pull: bitcoin#21686
Rebased-From: f979b32
@achow101 achow101 mentioned this pull request Apr 15, 2021
Merged
@benthecarman
Copy link
Contributor

ACK f979b32

achow101 added a commit to achow101/bitcoin that referenced this pull request Apr 15, 2021
@achow101
Add mainnet and testnet taproot activation params
724e494 
Github-Pull: bitcoin#21686
Rebased-From: f979b32
@leishman
Copy link
Contributor

ACK f979b32

@fanquake
Copy link
Member

Being backported in #21701.

achow101 added a commit to achow101/bitcoin that referenced this pull request Apr 16, 2021
@achow101
Add mainnet and testnet taproot activation params
cbd64c3 
Github-Pull: bitcoin#21686
Rebased-From: f979b32
maflcko pushed a commit that referenced this pull request Apr 16, 2021
Merge #21701: [0.21] Speedy trial activation for Taproot
e3b76b6 
cbd64c3 Add mainnet and testnet taproot activation params (Andrew Chow)
ec78243 chainparams: drop versionbits threshold to 90% for mainnnet and signet (Anthony Towns)
6003573 versionbits: simplify state transitions (Anthony Towns)
3acf037 versionbits: Add explicit NEVER_ACTIVE deployments (Anthony Towns)
b529222 fuzz: test versionbits delayed activation (Anthony Towns)
71917e0 tests: test versionbits delayed activation (Anthony Towns)
4cab84c versionbits: Add support for delayed activation (Anthony Towns)
f9517e6 tests: clean up versionbits test (Anthony Towns)
1c01645 tests: test ComputeBlockVersion for all deployments (Anthony Towns)
2e9e7f4 tests: pull ComputeBlockVersion test into its own function (Anthony Towns)

Pull request description:

  Backport of #21377 and #21686

ACKs for top commit:
  instagibbs:
    cherry-pick ACK cbd64c3
  jnewbery:
    ACK cbd64c3
  Sjors:
    tACK cbd64c3
  MarcoFalke:
    cherry-pick-only ACK cbd64c3 🌾

Tree-SHA512: e9efb0ca9986d685161bcba5ed43efdc5f1dca88322cf65faccf17009b567c2d930c2aba4d1541539fc65347574ed4faa3d4558b907c779d1c128b3d2c681f31
@harding harding mentioned this pull request Apr 18, 2021
Merged
@Rspigler Rspigler mentioned this pull request Apr 18, 2021
Merged
@bitcoin bitcoin deleted a comment from Kisha56 Nov 17, 2021
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luke-jr luke-jr luke-jr requested changes

@jonatack jonatack jonatack approved these changes

Assignees
No one assigned
Labels
Consensus Validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0