8000 depends, doc: List packages required to build `qt` package separately by hebasto · Pull Request #31192 · bitcoin/bitcoin · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

depends, doc: List packages required to build qt package separately #31192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2024
Merged

depends, doc: List packages required to build qt package separately #31192

merged 1 commit into from
Nov 5, 2024

Conversation

hebasto
Copy link
Member
@hebasto hebasto commented Oct 31, 2024

Suggested in #30997 (comment):

There's probably enough GUI-only stuff here, i.e bison, ninja-build, python3, xz-utils, that this could be moved to it's own #### Gui section.

@DrahtBot
Copy link
Contributor
DrahtBot commented Oct 31, 2024 •
edited
Loading

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/31192.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK fanquake
Concept ACK Sjors

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #30997 (build: Switch to Qt 6 by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

@hebasto hebasto mentioned this pull request Oct 31, 2024
Merged
fanquake
fanquake reviewed Oct 31, 2024
View reviewed changes
@DrahtBot
Copy link
Contributor

🚧 At least one of the CI tasks failed.
Debug: https://github.com/bitcoin/bitcoin/runs/32336801754

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

  • Possibly due to a silent merge conflict (the changes in this pull request being
    incompatible with the current code in the target branch). If so, make sure to rebase on the latest
    commit of the target branch.

  • A sanitizer issue, which can only be found by compiling with the sanitizer and running the
    affected test.

  • An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

@Sjors
Copy link
Member
Sjors commented Oct 31, 2024

Concept ACK.

Sjors
Sjors reviewed Oct 31, 2024
View reviewed changes
depends/README.md Outdated

Skip the following packages if you don't intend to use the GUI and will build with [`NO_QT=1`](#dependency-options):

apt install bison pkg-config python3 xz-utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest either leaving out apt install or also naming brew install and friends, to make it clear this applies to all platforms.

Copy link
Member Author
@hebasto hebasto Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't expect that all packages have the same names across Ubuntu/Debian and Homebrew repositories.

I agree that a macOS-specific section can be added here, but this is not a goal of this PR.