[28.x] Backports #32299
Merged
[28.x] Backports #32299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github-Pull: bitcoin#32187 Rebased-From: fa69c42
From the GNU make 3.82 release announcement: * The 'define' make directive now allows a variable assignment operator after the variable name, to allow for simple, conditional, or appending multi-line variable assignment. macOS ships with 3.81. This caused the multiprocess config options to be ignored. Fixes bitcoin#32068 Co-authored-by: Ryan Ofsky <ryan@ofsky.org> Github-Pull: bitcoin#32070 Rebased-From: 9157d9e
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. Code Coverage & BenchmarksFor details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32299. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. |
This is required for the next commit. Github-Pull: bitcoin#32336 Rebased-From: fa0c1ba
1dbb93a to
573460c
Compare
-BEGIN VERIFY SCRIPT-
ren() { sed --regexp-extended -i "s/$1/$2/g" $( git grep --extended-regexp -l "$1" ) ; }
ren 'cflags=\["-Wno-error=implicit-function-declaration"\]' 'cflags=bpf_cflags()'
-END VERIFY SCRIPT-
Github-Pull: bitcoin#32336
Rebased-From: facb9b3
573460c to
a325ca3
Compare
Fixed that up. |
willcl-ark
approved these changes
May 13, 2025
There was a problem hiding this comment.
ACK 812e637
Only changes to release note since previous ACK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
-Wduplicate-decl-specifierin bpfcc #32336