Use automatic version numbers in release builds #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
commented
Aug 2, 2023
| - -X github.com/bitrise-io/envman/version.Commit={{ .FullCommit }} | ||
| - -X github.com/bitrise-io/envman/version.BuildNumber={{ index .Env "BITRISE_BUILD_NUMBER" }} | ||
|
|
||
| archives: | ||
| # GitHub release should contain the raw binaries (no zip or tar.gz) | ||
| - format: binary | ||
| # Name format should match the curl install script | ||
| name_template: "{{ .ProjectName }}-{{ .Os }}-{{ .Arch }}" | ||
| replacements: |
There was a problem hiding this comment.
Deprecated and removed, no longer works.
There was a problem hiding this comment.
Did change from uppercase to lowercase in case of Darwin/Linux?
There was a problem hiding this comment.
No, the replacements option got deprecated and the suggested new way of doing things is with the name_template + Go templating
There was a problem hiding this comment.
Right, missed the "title" part from the template.
lpusok
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, this repo was still using hardcoded version strings (while all other binary tool repos use Goreleaser and
-ldflags.This PR aligns the release config to what we have in other repos.