8000 Upgrade to Go 1.23 by ofalvai · Pull Request #226 · bitrise-io/envman · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Upgrade to Go 1.23 #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2025
Merged

Upgrade to Go 1.23 #226

merged 5 commits into from
Jan 20, 2025

Conversation

ofalvai
Copy link
Contributor
@ofalvai ofalvai commented Jan 17, 2025 •
edited
Loading

Also fixes these vulns:

Vulnerability #1: GO-2024-2887
    Unexpected behavior from Is methods for IPv4-mapped IPv6 addresses in
    net/netip
  More info: https://pkg.go.dev/vuln/GO-2024-2887
  Standard library
    Found in: net/netip@go1.21.8
    Fixed in: net/netip@go1.21.11
    Vulnerable symbols found:
      #1: netip.Addr.IsGlobalUnicast
      #2: netip.Addr.IsInterfaceLocalMulticast
      #3: netip.Addr.IsLinkLocalMulticast
      #4: netip.Addr.IsLoopback
      #5: netip.Addr.IsMulticast
      Use '-show traces' to see the other 1 found symbols

Vulnerability #2: GO-2024-2687
    HTTP/2 CONTINUATION flood in net/http
  More info: https://pkg.go.dev/vuln/GO-2024-2687
  Standard library
    Found in: net/http@go1.21.8
    Fixed in: net/http@go1.21.9
    Vulnerable symbols found:
      #1: http.ProxyFromEnvironment

Your code is affected by 2 vulnerabilities from the Go standard library.
This scan also found 2 vulnerabilities in packages you import and 4
vulnerabilities in modules you require, but your code doesn't appear to call
these vulnerabilities.
Use '-show verbose' for more details.

ofalvai
ofalvai commented Jan 17, 2025
View reviewed changes
bitrise.yml
@@ -20,7 +29,7 @@ workflows:
#!/usr/bin/env bash
set -ex

curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.57.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed by Go version bump

ofalvai
ofalvai commented Jan 17, 2025
View reviewed changes
cli/clear.go
@@ -9,7 +9,7 @@ import (
"github.com/urfave/cli"
)

func clear(_ *cli.Context) error {
func clearEnvstore(_ *cli.Context) error {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clear is now a builtin function: https://tip.golang.org/ref/spec#Clear

@ofalvai ofalvai merged commit 7e737fe into master Jan 20, 2025
3 checks passed
@ofalvai ofalvai deleted the BE-1601-go-1.23 branch January 20, 2025 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpusok lpusok lpusok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofalvai @lpusok
0