8000 BIT-2413: Remove give feedback form link by matt-livefront · Pull Request #684 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BIT-2413: Remove give feedback form link #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

matt-livefront
Copy link
Collaborator

🎟️ Tracking

BIT-2413

📔 Objective

Removes the give feedback link from the about screen in settings.

📸 Screenshots

Before After
Screenshot 2024-06-21 at 8 59 19 AM Screenshot 2024-06-21 at 8 57 14 AM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor
1 Warning
⚠️ Ignoring duplicate libraries: '-lbitwarden_uniffi'
6 Messages
📖 BitwardenActionExtensionTests: Executed 0 tests, with 0 failures (0 expected) in 0 (0.001) seconds
📖 BitwardenAutoFillExtensionTests: Executed 0 tests, with 0 failures (0 expected) in 0 (0.0) seconds
📖 BitwardenShareExtensionTests: Executed 0 tests, with 0 failures (0 expected) in 0 (0.001) seconds
📖 BitwardenSharedTests: Executed 3219 tests, with 12 failures (0 expected) in 61.295 (63.261) seconds
📖 BitwardenTests: Executed 4 tests, with 0 failures (0 expected) in 0.442 (0.48) seconds
📖 NetworkingTests: Executed 26 tests, with 0 failures (0 expected) in 0.047 (0.055) seconds

Bitwarden code coverage

Total coverage: 86.24%

File Coverage
BitwardenShared/UI/Platform/Settings/Extensions/Alert+Settings.swift 100.00%
BitwardenShared/UI/Platform/Settings/Settings/About/AboutProcessor.swift 100.00%
BitwardenShared/UI/Platform/Settings/Settings/About/AboutState.swift 100.00%
BitwardenShared/UI/Platform/Settings/Settings/About/AboutView.swift 88.57%

Powered by Slather

Generated by 🚫 Danger

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2589c8ea-2615-4fd1-b473-0e0e4c5b3c36

No New Or Fixed Issues Found

@matt-livefront matt-livefront merged commit 0348e73 into main Jun 21, 2024
6 checks passed
@matt-livefront matt-livefront deleted the matt/BIT-2413-remove-give-feedback branch June 21, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0