BIT-2366: Alert user to switch to existing account with matching email on login #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitwarden code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| BitwardenShared/Core/Auth/Repositories/AuthRepository.swift | 97.24% |
| BitwardenShared/Core/Platform/Services/EnvironmentService.swift | 90.91% |
| BitwardenShared/Core/Platform/Services/StateService.swift | 97.48% |
| BitwardenShared/UI/Auth/Extensions/Alert+Auth.swift | 100.00% |
| BitwardenShared/UI/Auth/Landing/LandingProcessor.swift | 97.90% |
| BitwardenShared/UI/Auth/Landing/LandingView.swift | 92.80% |
Powered by Slather
Generated by 🚫 Danger
|
Fixed Issues
|
fedemkr
requested changes
Jun 25, 2024
fedemkr
reviewed
Jun 26, 2024
fedemkr
approved these changes
Jun 26, 2024
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BIT-2366
📔 Objective
On login, if the user's entered email matches an existing account and the base URLs match, present an alert to switch to that account.
📸 Screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-25.at.11.21.04.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes