BIT-2350: Add empty state when OTP matches no vault items #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitwarden code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| BitwardenShared/UI/Vault/Vault/VaultItemSelection/VaultItemSelectionProcessor.swift | 89.31% |
| BitwardenShared/UI/Vault/Vault/VaultItemSelection/VaultItemSelectionView.swift | 87.50% |
| BitwardenShared/UI/Vault/VaultItem/VaultItemCoordinator.swift | 95.45% |
Powered by Slather
Generated by 🚫 Danger
|
New Issues
Fixed Issues
|
fedemkr
reviewed
Jun 26, 2024
BitwardenShared/UI/Vault/Vault/VaultItemSelection/VaultItemSelectionView.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Vault/Vault/VaultItemSelection/VaultItemSelectionView.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #691 +/- ##
=======================================
Coverage ? 87.79%
=======================================
Files ? 562
Lines ? 27883
Branches ? 0
=======================================
Hits ? 24481
Misses ? 3402
Partials ? 0 ☔ View full report in Codecov by Sentry. |
fedemkr
reviewed
Jun 27, 2024
BitwardenShared/UI/Vault/Vault/VaultItemSelection/VaultItemSelectionView.swift
Show resolved
Hide resolved
BitwardenShared/UI/Vault/Vault/VaultItemSelection/VaultItemSelectionView.swift
Outdated
Show resolved
Hide resolved
fedemkr
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BIT-2350
📔 Objective
Adds the empty state when the OTP issuer doesn't match any items in the user's vault. This also populates the TOTP key field when tapping on either of the add item buttons.
📸 Screenshots
RPReplay_Final1719414384.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes