[PM-8965] Register for push notifications more aggressively #693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bitwarden code coverageTotal coverage:
|
| File | Coverage |
|---|---|
| BitwardenShared/UI/Platform/Application/AppProcessor.swift | 84.25% |
| BitwardenShared/UI/Vault/Vault/VaultCoordinator.swift | 99.25% |
| BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessor.swift | 96.57% |
Powered by Slather
Generated by 🚫 Danger
|
New Issues
Fixed Issues
|
fedemkr
reviewed
Jun 26, 2024
BitwardenShared/UI/Vault/Vault/VaultList/VaultListProcessor.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #693 +/- ##
=======================================
Coverage ? 87.74%
=======================================
Files ? 561
Lines ? 27832
Branches ? 0
=======================================
Hits ? 24422
Misses ? 3410
Partials ? 0 ☔ View full report in Codecov by Sentry. |
fedemkr
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8965
📔 Objective
Previously, the app was only registering for push notifications on launch, which meant that it would only register for an active user at that time. This now registers more aggressively, by checking any time the user goes to the vault list. It will also register after a user has granted permission for push notifications. However, it will also only attempt to register once per day (defined as 86400 seconds), to match the MAUI app.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes