10000 [PM-8052] Update Crowdin destination path by vvolkgang · Pull Request #694 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-8052] Update Crowdin destination path #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 26, 2024
Merged

Conversation

vvolkgang
Copy link
Member
@vvolkgang vvolkgang commented Jun 26, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9192

📔 Objective

This updates the Crowdin paths to ios and ios-watch directories instead of long trees.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor
github-actions bot commented Jun 26, 2024
1 Warning
⚠️ Ignoring duplicate libraries: '-lbitwarden_uniffi'
6 Messages
📖 BitwardenActionExtensionTests: Executed 0 tests, with 0 failures (0 expected) in 0 (0.001) seconds
📖 BitwardenAutoFillExtensionTests: Executed 0 tests, with 0 failures (0 expected) in 0 (0.001) seconds
📖 BitwardenShareExtensionTests: Executed 0 tests, with 0 failures (0 expected) in 0 (0.001) seconds
📖 BitwardenSharedTests: Executed 3282 tests, with 12 failures (0 expected) in 58.136 (59.023) seconds
📖 BitwardenTests: Executed 4 tests, with 0 failures (0 expected) in 0.44 (0.464) seconds
📖 NetworkingTests: Executed 26 tests, with 0 failures (0 expected) in 0.041 (0.048) seconds

Bitwarden code coverage

Total coverage: 86.23%

Powered by Slather

Generated by 🚫 Danger

Copy link
Contributor
github-actions bot commented Jun 26, 2024

Logo
Checkmarx One – Scan Summary & Detailsba93f29b-83e7-4950-8ee9-2fee1ddd4edd

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode changed the title Update crowdin.yml [PM-9192] Update Crowdin destination path Jun 26, 2024
@KatherineInCode KatherineInCode marked this pull request as ready for review June 26, 2024 20:15
@KatherineInCode KatherineInCode requested a review from a team June 26, 2024 20:15
Copy link
codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@e695800). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #694   +/-   ##
=======================================
  Coverage        ?   87.74%           
=======================================
  Files           ?      561           
  Lines           ?    27818           
  Branches        ?        0           
=======================================
  Hits            ?    24408           
  Misses          ?     3410           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vvolkgang vvolkgang merged commit eca5364 into main Jun 26, 2024
8 checks passed
@vvolkgang vvolkgang deleted the vvolkgang-patch-1 branch June 26, 2024 23:45
@KatherineInCode KatherineInCode changed the title [PM-9192] Update Crowdin destination path [PM-8052] Update Crowdin destination path Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0