8000 [PM-8052] Fix Crowdin push workflow location by KatherineInCode · Pull Request #711 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-8052] Fix Crowdin push workflow location #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9193

📔 Objective

The crowdin-push.yml workflow is in the wrong location, and is not treated as a workflow. This puts it in the correct location, and has the branch-matching updated to be like other workflows

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode requested a review from a team July 8, 2024 14:14
@KatherineInCode KatherineInCode marked this pull request as ready for review July 8, 2024 14:14
Copy link
codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.82%. Comparing base (fc8a41b) to head (a9bccf5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
- Coverage   87.82%   87.82%   -0.01%     
==========================================
  Files         562      562              
  Lines       27973    27973              
==========================================
- Hits        24567    24566       -1     
- Misses       3406     3407       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor
github-actions bot commented Jul 8, 2024

Logo
Checkmarx One – Scan Summary & Details24234be7-42a1-425d-961a-0a9651dcabf7

No New Or Fixed Issues Found

@KatherineInCode KatherineInCode merged commit d600346 into main Jul 8, 2024
8 checks passed
@KatherineInCode KatherineInCode deleted the pm-9193/crowdin-push-fix branch July 8, 2024 14:38
< 73F5 div class="TimelineItem-badge ">
@KatherineInCode KatherineInCode changed the title [PM-9193] Fix Crowdin push workflow location [PM-8052] Fix Crowdin push workflow location Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0