8000 BIT-2362 - Maximum Access Count Field Cannot Have A Value Entered In Manually by phil-livefront · Pull Request #714 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

BIT-2362 - Maximum Access Count Field Cannot Have A Value Entered In Manually #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 9, 2024
Merged

BIT-2362 - Maximum Access Count Field Cannot Have A Value Entered In Manually #714

merged 6 commits into from
Jul 9, 2024

Conversation

phil-livefront
Copy link
Collaborator

🎟️ Tracking

BIT-2362

📔 Objective

  • Allow the user to edit of the maximum access count from a numerical keyboard instead of just using the stepper to increase/decrease the count.
  • From figma: "the maximum access count is blank on default, then displays the count when edited. If the users sets it back to 0 after editing, it displays 0."
  • Added a "Save" button to the numerical keyboard to control the focus of the TextField for keyboard dismissal.

📸 Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-07-08.at.13.13.07.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov Codecov
Copy link
codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.89%. Comparing base (abfb354) to head (8c0d7b8).

Files Patch % Lines
...SendItem/AddEditSendItem/AddEditSendItemView.swift 95.23% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #714   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files         563      563           
  Lines       28131    28152   +21     
=======================================
+ Hits        24725    24745   +20     
- Misses       3406     3407    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jul 8, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 226a4e7f-2b18-4de7-9a29-e5118aba492f

No New Or Fixed Issues Found

fedemkr
fedemkr reviewed Jul 8, 2024
View reviewed changes
matt-livefront
matt-livefront approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator
@matt-livefront matt-livefront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@phil-livefront phil-livefront merged commit 58f8589 into main Jul 9, 2024
8 checks passed
@phil-livefront phil-livefront deleted the phil/BIT-2362-maximum-field-count-bug-fix branch July 9, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedemkr fedemkr fedemkr approved these changes

@matt-livefront matt-livefront matt-livefront approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-livefront @fedemkr @matt-livefront
0