BIT-2410: Support managed app config environment URLs #731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 573 573
Lines 28456 28467 +11
=======================================
+ Hits 25070 25081 +11
Misses 3386 3386 ☔ View full report in Codecov by Sentry. |
fedemkr
approved these changes
Jul 12, 2024
Sign up for free
to join this co
69B5
nversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
BIT-2410
📔 Objective
If an MDM pushes an app config profile to a device, the app should use the pre-configured URLs by default. If there's an existing account on the device, that account should still continue to work, but the pre-auth URLs should be set to the pre-configured URLs when adding any additional accounts.
App config settings are specified in UserDefaults under the
com.apple.configuration.managedkey. The base URL setting is specified within that dictionary with thebaseEnvironmentUrlkey.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes