[PM-8828] Fido2 autofill without user interaction #744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock the vault in the current session.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #744 +/- ##
==========================================
- Coverage 88.21% 88.18% -0.03%
==========================================
Files 573 575 +2
Lines 28571 28734 +163
==========================================
+ Hits 25203 25339 +136
- Misses 3368 3395 +27 ☔ View full report in Codecov by Sentry. |
8000
|
No New Or Fixed Issues Found |
…InCurrentSession to hasBeenUnlockedInteractively
…' into mobiletf/pm-8828/fido2-autofill-without-user-interaction
BitwardenShared/Core/Autofill/Utilities/Fido2DebugginReportBuilder.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/UI/Platform/Application/AppProcessorTests.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/Core/Vault/Services/Fido2CredentialStoreServiceTests.swift
Show resolved
Hide resolved
BitwardenShared/Core/Autofill/Utilities/Fido2DebugginReportBuilder.swift
Outdated
Show resolved
Hide resolved
Base automatically changed from
mobiletf/pm-8361/fido2-has-unlocked-current-transaction
to
main
July 18, 2024 18:17
KatherineInCode
previously approved these changes
Jul 18, 2024
BitwardenShared/Core/Autofill/Models/Fido2CredentialAutofillViewExtensionsTests.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/Core/Autofill/Services/AutofillCredentialService.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/Core/Autofill/Services/AutofillCredentialServiceTests.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-8828
📔 Objective
Perform autofill without user interaction. For this we need the next conditions to happen:
Notes:
Fido2DebugginReportBuilder:I added this to have a common place where I can add objects of the Fido2 flow to ease the debugging when an error or something unexpected occurs. I haven't added unit tests for this given that I only use it on Debug and I'll remove it as soon as I have all flows working. Same to the places where this is called.📸 Screenshots
Fido2.Autofill.without.User.interaction.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes