[PM-9849] Fido2 creation list selection #761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…al with passkey request parameters to be in AutofillCredentialService to reuse the logic in there with the SDK.
…ocessor to the VaultRepository and fix race condition issue with available credentials for authentication.
…ing a passkey as a new login when the list is empty or selecting an item from the list, loading it accordingly.
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## mobiletf/pm-8829/fido2-autofill-list #761 +/- ##
========================================================================
+ Coverage 88.12% 88.19% +0.06%
========================================================================
Files 577 577
Lines 29104 29221 +117
========================================================================
+ Hits 25648 25771 +123
+ Misses 3456 3450 -6 ☔ View full report in Codecov by Sentry. |
|
Closing to ease merging conflicts with new PR -> #763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-9849
📔 Objective
Create Fido2 credential by picking a credential from the list and/or saving a passkey as a new login.
📸 Screenshots
Fido2.creation.list.selection.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes