[PM-10450] Fix FIdo2 never lock user verification not appearing #787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ws, so it waits until the view has appeared in order to continue prompting the user.
8000
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
==========================================
- Coverage 88.19% 88.16% -0.03%
==========================================
Files 577 577
Lines 29213 29229 +16
==========================================
+ Hits 25763 25771 +8
- Misses 3450 3458 +8 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
matt-livefront
approved these changes
Aug 2, 2024
Comment on lines
+436
to
+439
| // WORKAROUND: We need to wait until the view controller appears in order to perform any | ||
| // action that needs user interaction or it might not show the prompt to the user. | ||
| // E.g. without this there are certain devices that don't show the FaceID prompt | ||
| // and the user only sees the screen dimming a bit and failing the flow. |
|
|
||
| // WORKAROUND: We need to wait until the view controller appears in order to perform any | ||
| // action that needs user interaction or it might not show the prompt to the user. | ||
| // E.g. without this there are certain devices that don't show the FaceID prompt |
There was a problem hiding this comment.
⛏️ "E.g." means "for example" ("exempli gratia"); if you want "that is" or "in other words", that'd be "i.e." ("id est")
There was a problem hiding this comment.
I wanted exampli gratia, as there are other cases in which this happens as setting up the PIN.
| @@ -2,6 +2,7 @@ import AuthenticationServices | |||
| import BitwardenSdk | |||
| import Combine | |||
| import Foundation | |||
| import OSLog | |||
There was a problem hiding this comment.
⛏️ If we don't have logs in the file we shouldn't have this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-10450
📔 Objective
Fix Fido2 flow user verification not appearing when in an account with never lock timeout.
The problem arises because of trying to perform user interaction, e.g. prompting for FaceID, before
viewDidAppearhappens. So as a solution we just for it to happen before continuing with user interaction flows.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes