8000 [PM-9501][PM-13032] Update keyboard behavior for Notes field by phil-livefront · Pull Request #798 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-9501][PM-13032] Update keyboard behavior for Notes field #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Oct 22, 2024
Merged

[PM-9501][PM-13032] Update keyboard behavior for Notes field #798

merged 18 commits into from
Oct 22, 2024

Conversation

phil-livefront
Copy link
Collaborator
@phil-livefront phil-livefront commented Aug 6, 2024 •
edited
Loading

🎟️ Tracking

PM-9501
PM-12032

📔 Objective

  • Enhance Notes Section: Implemented a UITextView-based section for the Notes feature to improve keyboard and cursor management. This was updated on ViewItemView, AddEditItemView, AddEditSendItemView.
  • Enable Partial Text Selection: Added support for partial text selection in the UITextView view, resolving issues with copying and pasting within the Notes section.
  • The snapshot tests encountered problems with the multiline height changes due to the need for the @State property to be updated when the text view's height increases. I've provided a video that shows the feature functioning correctly and scaling appropriately with text size increases.

📸 Screenshots

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-10-22.at.01.08.13.mp4

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov Codecov
Copy link
codecov bot commented Aug 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.00699% with 10 lines in your changes missing coverage. Please review.

Project coverage is 89.36%. Comparing base (8bcb21f) to head (545352e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...atform/Application/Views/BitwardenUITextView.swift 87.93% 7 Missing ⚠️
...SendItem/AddEditSendItem/AddEditSendItemView.swift 92.85% 2 Missing ⚠️
.../Vault/VaultItem/AddEditItem/AddEditItemView.swift 96.15% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #798      +/-   ##
==========================================
+ Coverage   89.35%   89.36%   +0.01%     
==========================================
  Files         672      672              
  Lines       42253    42326      +73     
==========================================
+ Hits        37755    37825      +70     
- Misses       4498     4501       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Aug 6, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – ea40c59e-aa48-4492-ab8d-3584a6801db8

No New Or Fixed Issues Found

@phil-livefront phil-livefront marked this pull request as draft August 13, 2024 04:59
@vvolkgang vvolkgang changed the title PM-9501 - Update keyboard behavior for Notes field [PM-9501][PM-13032] - Update keyboard behavior for Notes field Oct 16, 2024
@vvolkgang vvolkgang changed the title [PM-9501][PM-13032] - Update keyboard behavior for Notes field [PM-9501][PM-13032] Update keyboard behavior for Notes field Oct 16, 2024
@vvolkgang vvolkgang reopened this Oct 16, 2024
@phil-livefront phil-livefront marked this pull request as ready for review October 22, 2024 05:26
This was linked to issues Oct 22, 2024
Unable to select text in a Secure Notes/Login "Notes" field #942
Closed
Unable to select text in a notes field #899
Closed
@fedemkr fedemkr mentioned this pull request Oct 22, 2024
Open
2 tasks
@fedemkr fedemkr linked an issue Oct 22, 2024 that may be closed by this pull request
Tapping on the contents of a Secure Note whilst in Edit mode causes the view to scroll down to the bottom of the text. #931
Closed
2 tasks
fedemkr
fedemkr previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member
@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good great job! 🎉

matt-livefront
matt-livefront reviewed Oct 22, 2024
View reviewed changes
@phil-livefront phil-livefront merged commit 861b171 into main Oct 22, 2024
9 checks passed
@phil-livefront phil-livefront deleted the phil/PM-9501-notes-section-keyboard-issues branch October 22, 2024 19:27
matt-livefront pushed a commit that referenced this pull request Oct 28, 2024
@phil-livefront @matt-livefront
[PM-9501][PM-13032] Update keyboard behavior for Notes field (#798)
a60596e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matt-livefront matt-livefront matt-livefront approved these changes

@fedemkr fedemkr fedemkr left review comments

@KatherineInCode KatherineInCode Awaiting requested review from KatherineInCode

@victor-livefront victor-livefront Awaiting requested review from victor-livefront

@brant-livefront brant-livefront Awaiting requested review from brant-livefront

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@phil-livefront @fedemkr @matt-livefront @vvolkgang
0