[PM-10773] Issue #810: Add accessibility element modifier to VaultListSectionView so that section name and item count are treated as a single element by VoiceOver. #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e accessibilityElement modifier to the HStack.
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
2 tasks
KatherineInCode
approved these changes
Aug 14, 2024
|
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #812 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 581 581
Lines 29407 29408 +1
=======================================
+ Hits 25945 25946 +1
Misses 3462 3462 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
#810
📔 Objective
Currently, the VoiceOver screenreader, used by blind iOS users, will treat the title and item count displayed in the header of each vault section as separate elements, making navigation cumbersome and resulting in an unclear relationship between these two elements from an accessibility perspective. This PR addresses the issue with a simple one-line fix, adding an accessibility element modifier to the HStack in VaultListSectionView that combines these 2 views into a single accessibility element.
This fix also has the potential to improve the experience for other accessibility features as well, such as Switch Control and Voice Control.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes