PM-10266: Master password guidance screen #828
Conversation
|
No New Or Fixed Issues Found |
a85409f to
07790bd
Compare
…266-master-password-guidance-screen
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #828 +/- ##
==========================================
+ Coverage 88.59% 88.60% +0.01%
==========================================
Files 618 620 +2
Lines 39070 39185 +115
==========================================
+ Hits 34615 34721 +106
- Misses 4455 4464 +9 ☔ View full report in Codecov by Sentry. |
…266-master-password-guidance-screen
...ed/UI/Auth/CompleteRegistration/MasterPasswordGuidance/MasterPasswordGuidanceProcessor.swift
Outdated
Show resolved
Hide resolved
...nShared/UI/Auth/CompleteRegistration/MasterPasswordGuidance/MasterPasswordGuidanceView.swift
Outdated
Show resolved
Hide resolved
| /// Create a line of text with a bullet point in front of it. | ||
| /// | ||
| private func bulletPoint(text: String) -> some View { | ||
| HStack(alignment: .top, spacing: 6) { | ||
| Text("•") | ||
|
|
||
| Text(text) | ||
| } | ||
| .styleGuide(.subheadline) | ||
| .foregroundStyle(Asset.Colors.textSecondary.swiftUIColor) | ||
| } |
There was a problem hiding this comment.
There was a problem hiding this comment.
good call out. im not sure i know how to get this to work with RTL. Do you have any idea or is there examples elsewhere in the app that you know of?
There was a problem hiding this comment.
Can you confirm this doesn't work with RTL? I think SwiftUI might flip the UI by default.
There was a problem hiding this comment.
this is what im seeing when i force the layout. since its english, the words arent RTL but the bullet point appears to work.
#Preview {
MasterPasswordGuidanceView(
store: Store(
processor: StateProcessor(
state: ()
)
)
)
.environment(\.layoutDirection, .rightToLeft)}
There was a problem hiding this comment.
In the simulator (iPhone 15 Pro iOS 17.0.1), it's not currently changing. Although I see it doesn't change language correctly either. Testing on my device now.
There was a problem hiding this comment.
Same behavior on Device, it seems that there's an issue on RTL languages. So I think we're good for this PR and we can tackle the RTL languages problem in another PR.
🎟️ Tracking
PM-10266
📔 Objective
Create the "Master password guidance" informational screen.
This screen is not currently reachable in the app since we don't have the updated implementation of the "choose your master password" screen with the "what makes a password strong" button on it. To view this screen, you can call
showMasterPasswordGuidance()from one of the other routes inAuthCoordinator.navigate(to:context:).📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes