[PM-10562] Added the complication to the watchOS app #836
Conversation
…r watchOS 8 and WidgetKit for watchOS 9+.
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #836 +/- ##
=======================================
Coverage 88.64% 88.64%
=======================================
Files 615 615
Lines 30621 30621
=======================================
Hits 27144 27144
Misses 3477 3477 ☔ View full report in Codecov by Sentry. |
Configs/WatchCommon.xcconfig
Outdated
| #include "./Common.xcconfig" | ||
| #include? "./Local.xcconfig" | ||
|
|
||
| BASE_WATCH_BUNDLE_ID = $(BASE_BUNDLE_ID).watchkitapp |
There was a problem hiding this comment.
⛏️ Newline at end of file
BitwardenWatchApp/Info.plist
Outdated
| @@ -2,6 +2,8 @@ | |||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | |||
| <plist version="1.0"> | |||
| <dict> | |||
| <key>CLKComplicationPrincipalClass</key> | |||
There was a problem hiding this comment.
🎨 If you run this through plutil (plutil -convert xml1 Info.plist), it will automatically alphabetize the keys for you (in addition to just cleaning up the formatting in general).
There was a problem hiding this comment.
Awesome nice trick thanks!
| #Preview(as: .accessoryCorner) { | ||
| BitwardenWatchWidgetExtension() | ||
| } timeline: { | ||
| SimpleEntry(date: .now) | ||
| } |
There was a problem hiding this comment.
🤔 I suspect the answer is "no", but is there any way we can do snapshot tests of this?
There was a problem hiding this comment.
I'd need to check but my intention was to bring this up in the next mobile meeting given that we don't have tests in the watchOS target neither. So if we add them here we'd need to add them in the watch app as well.
There was a problem hiding this comment.
Definitely something to discuss, but I'm comfortable not doing them right now. I kinda feel like revamping the watch app and bringing it a bit in line with our naming/architecture conventions of the main app is something we should also look at in general, and that would be a good time to do that.
There was a problem hiding this comment.
Yes, totally agree. I've added a spike to check whether we can add the test structure to the watchOS app and the widget extension and also another ticket for the watchOS app architecture/code guidelines update.
🎟️ Tracking
PM-10562
📔 Objective
Fix complication for watchOS 8 and added the complication for watchOS 9+ using WidgetKit.
Additionally, fixed a unit test that was sometimes failing due to a race condition:
AutofillCredentialServiceTests -> test_syncIdentities_removeDisabled📸 Screenshots
watchOS 10
watchOS 8
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes