8000 PM-11120: Update SDK to aee1a04 by matt-livefront · Pull Request #840 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PM-11120: Update SDK to aee1a04 #840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Conversation

matt-livefront
Copy link
Collaborator
@matt-livefront matt-livefront commented Aug 19, 2024

🎟️ Tracking

PM-11120

📔 Objective

Updates the SDK to the latest version (aee1a04).

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
Contributor
github-actions bot commented Aug 19, 2024

Logo
Checkmarx One – Scan Summary & Details41a72e28-440d-459e-a446-a054081f4ee3

No New Or Fixed Issues Found

@matt-livefront matt-livefront requested a review from fedemkr August 19, 2024 15:07
Copy link
codecov bot commented Aug 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (98ed38e) to head (f8c4c4f).
Report is 1 commits behind head on main.

Files Patch % Lines
...Shared/Core/Auth/Repositories/AuthRepository.swift 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
- Coverage   88.52%   88.51%   -0.01%     
==========================================
  Files         606      606              
  Lines       30259    30262       +3     
==========================================
+ Hits        26786    26787       +1     
- Misses       3473     3475       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-livefront matt-livefront merged commit 6cba789 into main Aug 19, 2024
8 checks passed
@matt-livefront matt-livefront deleted the matt/PM-11120-update-sdk branch August 19, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development
3847

Successfully merging this pull request may close these issues.

2 participants
0