8000 PM-11156: Remove leave organization API request by matt-livefront · Pull Request #853 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PM-11156: Remove leave organization API request #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2024
Merged

PM-11156: Remove leave organization API request #853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions BitwardenShared/Core/Auth/Services/API/Organization/OrganizationAPIService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ protocol OrganizationAPIService {
/// - Returns: A `SingleSignOnDetailsResponse`.
///
func getSingleSignOnDetails(email: String) async throws -> SingleSignOnDetailsResponse

/// Removes the user from an organization.
///
/// - Parameter organizationId: The organization's ID.
///
func leaveOrganization(organizationId: String) async throws
}

extension APIService: OrganizationAPIService {
Expand All @@ -42,8 +36,4 @@ extension APIService: OrganizationAPIService {
func getSingleSignOnDetails(email: String) async throws -> SingleSignOnDetailsResponse {
try await apiUnauthenticatedService.send(SingleSignOnDetailsRequest(email: email))
}

func leaveOrganization(organizationId: String) async throws {
_ = try await apiService.send(LeaveOrganizationRequest(organizationId: organizationId))
}
}
23 changes: 0 additions & 23 deletions BitwardenShared/Core/Auth/Services/API/Organization/OrganizationAPIServiceTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,27 +68,4 @@ class OrganizationAPIServiceTests: BitwardenTestCase {
SingleSignOnDetailsResponse(organizationIdentifier: "TeamLivefront", ssoAvailable: true)
)
}

/// `leaveOrganization(organizationId:)` removes the user from the organization.
func test_leaveOrganization() async throws {
client.result = .httpSuccess(testData: .emptyResponse)

await assertAsyncDoesNotThrow {
_ = try await subject.leaveOrganization(organizationId: "1")
}

let request = try XCTUnwrap(client.requests.first)
XCTAssertEqual(request.method, .post)
XCTAssertEqual(request.url.relativePath, "/api/organizations/1/leave")
XCTAssertNil(request.body)
}

/// `leaveOrganization(organizationId:)` throws an error if the request fails.
func test_leaveOrganization_httpFailure() async throws {
client.result = .httpFailure()

await assertAsyncThrows {
_ = try await subject.leaveOrganization(organizationId: "1")
}
}
}
20 changes: 0 additions & 20 deletions BitwardenShared/Core/Auth/Services/API/Organization/Requests/LeaveOrganizationRequest.swift
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions ...enShared/Core/Auth/Services/API/Organization/Requests/LeaveOrganizationRequestTests.swift
View file
Open in desktop

This file was deleted.

Loading
0