8000 [PM-11710] Updated SDK reference by fedemkr · Pull Request #905 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-11710] Updated SDK reference #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

fedemkr
Copy link
Member
@fedemkr fedemkr commented Sep 6, 2024

🎟️ Tracking

PM-11710

📔 Objective

Fix Cryptographic error on login by updating the SDK reference which instead of throwing InvalidKey error, it ignores it.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

… fix a bug when initializing private keys. So now it just ignores the InvalidKey error instead of throwing.
Copy link
Contributor
github-actions bot commented Sep 6, 2024

Logo
Checkmarx One – Scan Summary & Detailsf237ac00-b906-4653-87e9-d599e1e15f6d

No New Or Fixed Issues Found

…keys. So now it just ignores the InvalidKey error instead of throwing.
@fedemkr fedemkr requested review from matt-livefront and a team September 6, 2024 13:10
@fedemkr fedemkr marked this pull request as ready for review September 6, 2024 13:11
Copy link
codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (aa6ba21) to head (4b5d84a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #905   +/-   ##
=======================================
  Coverage   88.77%   88.77%           
=======================================
  Files         617      617           
  Lines       30898    30906    +8     
=======================================
+ Hits        27430    27438    +8     
  Misses       3468     3468           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fedemkr fedemkr merged commit c3f3a13 into main Sep 6, 2024
8 checks passed
@fedemkr fedemkr deleted the pm-11710/update-sdk-revision branch September 6, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0