8000 [PM-10877] New workflows for version calculation and workflow dispatch by vvolkgang · Pull Request #915 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-10877] New workflows for version calculation and workflow dispatch #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

vvolkgang
Copy link
Member
@vvolkgang vvolkgang commented Sep 10, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-10877

📔 Objective

First step in moving version calculation to it's own file. Also adds a new composite action to dispatch, wait and download artifacts from other workflows. We need these in main before we're able to use them in our existing build related workflows.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang changed the title [ PM-10877] New workflows for version calculation and workflow dispatch [PM-10877] New workflows for version calculation and workflow dispatch Sep 10, 2024
Copy link
codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.55%. Comparing base (7d1437f) to head (c6c2288).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #915      +/-   ##
==========================================
- Coverage   88.80%   88.55%   -0.25%     
==========================================
  Files         617      617              
  Lines       30931    38911    +7980     
==========================================
+ Hits        27468    34459    +6991     
- Misses       3463     4452     +989     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details100706f8-4884-43e4-b1b4-b665c57d70fd

No New Or Fixed Issues Found

@vvolkgang vvolkgang merged commit 54ad9f5 into main Sep 17, 2024
7 of 8 checks passed
@vvolkgang vvolkgang deleted the new-version-calc branch September 17, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0