10000 PM-12312: Update autofill setup progress when account is created and autofill is enabled by matt-livefront · Pull Request #963 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PM-12312: Update autofill setup progress when account is created and autofill is enabled #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

matt-livefront
Copy link
Collaborator
@matt-livefront matt-livefront commented Sep 23, 2024

🎟️ Tracking

PM-12312

📔 Objective

During the new create account flow, if a new account is created and autofill is already enabled for the app, the setup autofill screen should not be shown to the user. This bypasses the autofill screen by setting the user's autofill setup progress to complete when the account is created.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.75%. Comparing base (4d41969) to head (1cc796e).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #963   +/-   ##
=======================================
  Coverage   88.75%   88.75%           
=======================================
  Files         638      638           
  Lines       40033    40038    +5     
=======================================
+ Hits        35531    35536    +5     
  Misses       4502     4502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details4088c8cc-23cb-4fb4-b0be-baf0cd33bca9

No New Or Fixed Issues Found

@matt-livefront matt-livefront merged commit 6827509 into main Sep 24, 2024
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-12312-account-setup-autofill branch September 24, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0