PM-12779: Add account security set up unlock method action card #984
Conversation
| /// - includeLinePadding: A flag to indicate if the style should apply padding around the | ||
| /// view to account for the font's line height. Defaults to `true`. |
There was a problem hiding this comment.
The style guide modifier adds extra padding to text to try and match the line height of the font in Figma. But this was causing some issues when trying to align the views at the top of the action card, where the text was too low compared to the badge and close button.
| // Add custom horizontal and vertical padding to ensure the frame of the badge is a | ||
| // square. When the view is clipped to a circle, this ensures the frame of the view | ||
| // matches the size of the circle. Otherwise, clipping can cause there to be extra | ||
| // space in the frame which can affect the layout when the badge is used. | ||
| 8000 | .padding(.horizontal, (circleDiameter - textSize.width) / 2 + badgePadding) | |
| .padding(.vertical, (circleDiameter - textSize.height) / 2 + badgePadding) |
There was a problem hiding this comment.
Without these changes, the frame of the badge had extra vertical padding when displaying text that was taller than wider. This was also causing alignment issues at the top of action card.
| Before | After |
|---|---|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #984 +/- ##
==========================================
+ Coverage 88.77% 88.83% +0.05%
==========================================
Files 638 643 +5
Lines 40129 40366 +237
==========================================
+ Hits 35625 35859 +234
- Misses 4504 4507 +3 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
Thanks, I added tests for the action card. The view extension would be hard to test. |
🎟️ Tracking
PM-12779
📔 Objective
Adds a new action card to the account security settings menu for setting up an unlock method.
📸 Screenshots
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-09-27.at.16.28.28.mp4
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes