[BITAU-174] [BITAU-151] Remove shared items and key when a user disables sync #1004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to-coredata-store
…ges out of DataStore to prepare for refactor in the brant/create-coredata-store branch
… Keep DataStore generic
…M app CoreData semantics. Refactor conveience methods to new service class
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1004 +/- ##
=======================================
Coverage 89.07% 89.07%
=======================================
Files 660 660
Lines 41292 41304 +12
=======================================
+ Hits 36781 36793 +12
Misses 4511 4511 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
fedemkr
reviewed
Oct 3, 2024
BitwardenShared/Core/Platform/Services/AuthenticatorSyncService.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/Core/Platform/Services/AuthenticatorSyncService.swift
Outdated
Show resolved
Hide resolved
fedemkr
reviewed
Oct 4, 2024
fedemkr
previously approved these changes
Oct 7, 2024
Base automatically changed from
brant/BITAU-152-handle-vault-lock-unlock
to
main
October 7, 2024 16:56
|
@fedemkr This dismissed your approval because this was re-targeted to |
fedemkr
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
This PR cleans up the DataStore and keys when a user disables sync. When a user disables sync (after turning it on) for an account, we delete all of that account's items from the shared store. We then check to see if this was the last account to have sync turned on. If there are no other accounts with sync turned on, we then delete the main shared Authenticator key from the App Group keychain. If there are more accounts still with sync turned on, we leave the key in place.
This allows a user to turn off sync for one or all of their accounts and we clear everything up so that there's no left over data from having turned sync on.
Note: This PR is based off of the branch for this open PR. The other PR would need to be approved/merged first, or this will merge into that PR and wait for it to be approved/merge.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes