8000 PM-11142 - Implement empty vault screen UI by phil-livefront · Pull Request #1018 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PM-11142 - Implement empty vault screen UI #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ struct CompleteRegistrationView: View {
title: Localizations.chooseYourMasterPassword,
message: Localizations.chooseAUniqueAndStrongPasswordToKeepYourInformationSafe
)
.padding(.top, 40)

learnMoreSection
.padding(.vertical, 16)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ struct VaultUnlockSetupView: View {
title: Localizations.setUpUnlock,
message: Localizations.setUpBiometricsOrChooseAPinCodeToQuicklyAccessYourVaultAndAutofillYourLogins
)
.padding(.top, 40)

VStack(spacing: 0) {
ForEach(store.state.unlockMethods) { unlockMethod in
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{
"images" : [
{
"filename" : "items_light.pdf",
"idiom" : "universal"
},
{
"appearances" : [
{
"appearance" : "luminosity",
"value" : "dark"
}
],
"filename" : "items_dark.pdf",
"idiom" : "universal"
}
],
"info" : {
"author" : "xcode",
"version" : 1
},
"properties" : {
"preserves-vector-representation" : true
}
}
Binary file not shown.
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -1002,3 +1002,5 @@
"AutoFillActivatedDescriptionLong" = "You can now use autofill to log into apps and websites using your saved passwords. Now, you can explore everything else Bitwarden has to offer.";
"GetStarted" = "Get started";
"Dismiss" = "Dismiss";
"SaveAndProtectYourData" = "Save and protect your data";
"TheVaultProtectsMoreThanJustPasswordsStoreSecureLoginsIdsCardsAndNotesSecurelyHere" = "The vault protects more than just your passwords. Store secure logins, IDs, cards and notes securely here.";
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ struct PageHeaderView: View {
.styleGuide(.body)
}
}
.padding(.top, 40)
.foregroundStyle(Asset.Colors.textPrimary.swiftUIColor)
.multilineTextAlignment(.center)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ struct ExtensionActivationView: View {
title: Localizations.youreAllSet,
message: Localizations.autoFillActivatedDescriptionLong
)
.padding(.top, 40)

Button(Localizations.continueToBitwarden) {
openURL(ExternalLinksConstants.appDeepLink)
Expand Down
23 changes: 17 additions & 6 deletions BitwardenShared/UI/Vault/Vault/VaultList/VaultListView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,26 @@ private struct SearchableVaultListView: View {

Spacer()

Text(Localizations.noItems)
.multilineTextAlignment(.center)
.styleGuide(.callout)
.foregroundColor(Asset.Colors.textPrimary.swiftUIColor)
PageHeaderView(
image: Asset.Images.items,
title: Localizations.saveAndProtectYourData,
message: Localizations
.theVaultProtectsMoreThanJustPasswordsStoreSecureLoginsIdsCardsAndNotesSecurelyHere
)
.padding(.horizontal, 16)

Button(Localizations.addAnItem) {
Button {
store.send(.addItemPressed)
} label: {
HStack {
Image(decorative: Asset.Images.plus)
.resizable()
.frame(width: 16, height: 16)
Text(Localizations.addAnItem)
}
.padding(.horizontal, 24)
}
.buttonStyle(.tertiary())
.buttonStyle(.primary(shouldFillWidth: false))

Spacer()
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -176,15 +176,15 @@ class VaultListViewTests: BitwardenTestCase {
processor.state.profileSwitcherState.isVisible = false
processor.state.loadingState = .data([])

assertSnapshot(of: subject, as: .defaultPortrait)
assertSnapshots(of: subject, as: [.defaultPortrait, .defaultPortraitDark, .defaultLandscape])
}

@MainActor
func test_snapshot_empty_singleAccountProfileSwitcher() {
processor.state.profileSwitcherState.isVisible = true
processor.state.loadingState = .data([])

assertSnapshot(of: subject, as: .defaultPortrait)
assertSnapshots(of: subject, as: [.defaultPortrait, .defaultPortraitDark])
}

@MainActor
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
4A2C
Sorry, this file is invalid so it cannot be displayed.
Loading
0