[PM-11910] Improve Crashlytics logs #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype and customizing user info for CustomNSError on Error with associated values.
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
- Coverage 89.10% 89.06% -0.04%
==========================================
Files 657 660 +3
Lines 41317 41390 +73
==========================================
+ Hits 36814 36866 +52
- Misses 4503 4524 +21 ☔ View full report in Codecov by Sentry. |
matt-livefront
previously approved these changes
Oct 4, 2024
BitwardenShared/Core/Platform/Services/API/Errors/ServerError.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/Core/Platform/Services/EnvironmentService.swift
Outdated
Show resolved
Hide resolved
BitwardenShared/Core/Platform/Services/EnvironmentServiceTests.swift
Outdated
Show resolved
Hide resolved
…swift Co-authored-by: Matt Czech <matt@livefront.com>
Co-authored-by: Matt Czech <matt@livefront.com>
….swift Co-authored-by: Matt Czech <matt@livefront.com>
Co-authored-by: Matt Czech <matt@livefront.com>
matt-livefront
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-11910
📔 Objective
Improve Crashlytics error reports so we can identify issues causes easier.
UserIdto the reports.Region typeto the reports, i.e.US,EUorSelf-Hosted(no specific URL configuration is logged)CustomNSErroron someErrorwith associated values so that additional info can be set in theerrorUserInfoto be sent to Crashlytics and we have a better understanding on the context of such errors.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes