[PM-13193] Create Xcode version file #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1029 +/- ##
=======================================
Coverage 89.10% 89.10%
=======================================
Files 660 660
Lines 41392 41392
=======================================
Hits 36883 36883
Misses 4509 4509 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13193
📔 Objective
This creates a
.xcode-versionfile per the Fastlane proposal. There is a minor difference that format of the versions has to match how the setup-xcode expects it; the only place where this matters is with beta Xcode versions, which need to be e.g.16.1-betarather than the proposal's16.1b2. Because Fastlane currently does not do the build, there should be no interference there.As part of this, it made sense to add parameters to the
test.ymlworkflow to allow overriding the Xcode version, the simulator name, and simulator iOS version respectively. Currently the defaults for the latter two are still hardcoded in the workflow, which is not ideal—future ideas could be for.test-simulator-nameand.test-simulator-versionfiles, though that could clutter things up. While storing all of these defaults in one file could also work, that breaks the.xcode-versionfile proposal earlier, which could impede adopting Fastlane for building—though we would still run into that problem with the override.This lays the groundwork to more easily migrate to Xcode 16, and is part of the broader iOS 18 / Xcode 16 / Swift 6 effort.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes