PM-13432: Update toast design to support title and subtitle #1039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1039 +/- ##
==========================================
+ Coverage 89.15% 89.17% +0.02%
==========================================
Files 662 662
Lines 41596 41609 +13
==========================================
+ Hits 37085 37106 +21
+ Misses 4511 4503 -8 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
phil-livefront
previously approved these changes
Oct 14, 2024
| do { | ||
| try await Task.sleep(nanoseconds: 3 * NSEC_PER_SEC) | ||
| withAnimation { | ||
| self.toast = nil |
There was a problem hiding this comment.
this is not really possible to test, right?
There was a problem hiding this comment.
Right, I don't think there's a way we can trigger this with view inspector.
| func showToast(_ text: String) { | ||
| navigator?.showToast(Toast(text: text)) | ||
| func showToast(_ title: String, subtitle: String? = nil) { | ||
| navigator?.showToast(Toast(title: title, subtitle: subtitle)) |
There was a problem hiding this comment.
same question here, we can't test this, right?
There was a problem hiding this comment.
Added a test for this!
phil-livefront
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-13432
📔 Objective
Updates the design of the toasts to match the new design. This new design includes support for a title and subtitle which required a bit of refactoring from just the text that existed previously.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes