PM-11150: Add import logins step 1 #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 89.15% 89.19% +0.03%
==========================================
Files 662 665 +3
Lines 41608 41740 +132
==========================================
+ Hits 37097 37231 +134
+ Misses 4511 4509 -2 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
| // MARK: View | ||
|
|
||
| var body: some View { | ||
| _VariadicView.Tree(Layout()) { |
There was a problem hiding this comment.
is this part of swiftui's private view api? I should make a ticket to use this within PasswordAutoFillView
There was a problem hiding this comment.
Yeah, it is a private SwiftUI API, but it's used pretty extensively within SwiftUI. There's a few places in the app that we could make use of this after it's in.
phil-livefront
approved these changes
Oct 14, 2024
fedemkr
reviewed
Oct 14, 2024
BitwardenShared/UI/Platform/Application/Support/Localizations/en.lproj/Localizable.strings
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-11150
📔 Objective
Adds first step of import logins instructions. This also switches to using a new feature flag separately from the create account flow so they can be enabled separately if needed.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes