[PM-13015] Remember last opened view (View/Edit cipher) #1053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (currently View cipher and Edit cipher). UT not added yet.
|
No New Or Fixed Issues Found |
BitwardenShared/UI/Vault/VaultItem/ViewItem/ViewItemProcessor.swift
Outdated
Show resolved
Hide resolved
# Conflicts: # BitwardenShared/UI/Platform/Application/AppProcessor.swift
…ltiple accounts. Also changed the container for weak targets to be a WeakWrapper object to apply a common array instead of a NSPointerArray to be more like Swift language.
# Conflicts: # BitwardenShared/UI/Platform/Application/AppCoordinatorTests.swift
# Conflicts: # BitwardenShared/UI/Auth/Extensions/AuthRouter+Redirects.swift
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
+ Coverage 89.36% 89.38% +0.02%
==========================================
Files 677 679 +2
Lines 42817 42964 +147
==========================================
+ Hits 38262 38405 +143
- Misses 4555 4559 +4 ☔ View full report in Codecov by Sentry. |
| waitFor(!errorReporter.errors.isEmpty) | ||
| XCTAssertEqual(errorReporter.errors as? [BitwardenTestError], [.example]) | ||
| } | ||
|
|
There was a problem hiding this comment.
🔨 just a lint warning to clean up for file_length
There was a problem hiding this comment.
Done, nice catch, thanks!
phil-livefront
previously approved these changes
Oct 30, 2024
# Conflicts: # BitwardenShared/UI/Auth/Extensions/AuthRouter+Redirects.swift
matt-livefront
previously approved these changes
Nov 1, 2024
matt-livefront
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-13015
📔 Objective
This PR lays the grounds to remember the last opened view from the user when timeout lock happens.
So if user is automatically locked the last opened view with a minimum state will be saved and when the user unlocks, it will navigate to such view loading it.
This is currently constrained to:
And it's remembered for 5 minutes; after that unlocking will proceed to the default navigation.
📸 Screenshots
Remeber.last.opened.view.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes