8000 Remove header from workflow so it can lint by KatherineInCode · Pull Request #1076 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remove header from workflow so it can lint #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

KatherineInCode
Copy link
Contributor

📔 Objective

This updates a workflow to remove a line of dashes at the beginning that causes lint to fail. The fix is already on main, so it should merge fine

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode marked this pull request as ready for review October 24, 2024 14:10
@KatherineInCode KatherineInCode requested a review from a team as a code owner October 24, 2024 14:10
@KatherineInCode KatherineInCode merged commit c4a5ae9 into release/2024.10-rc1 Oct 24, 2024
6 checks passed
@KatherineInCode KatherineInCode deleted the katherine/update-workflows branch October 24, 2024 14:15
Copy link
codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.07%. Comparing base (63fd9b7) to head (360f57e).
Report is 2 commits behind head on release/2024.10-rc1.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           release/2024.10-rc1    #1076      +/-   ##
=======================================================
- Coverage                89.18%   89.07%   -0.11%     
=======================================================
  Files                      662      660       -2     
  Lines                    41621    41301     -320     
=======================================================
- Hits                     37118    36790     -328     
- Misses                    4503     4511       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsbb6af560-bc0f-42dd-beb1-3d6d58d61b1c

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5B4D
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0