8000 [PM-14033] Configure test workflow simulator type and iOS version with config files by KatherineInCode · Pull Request #1080 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-14033] Configure test workflow simulator type and iOS version with config files #1080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 25, 2024
Merged

[PM-14033] Configure test workflow simulator type and iOS version with config files #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f5445dd
Pull test simulator information into separate files
KatherineInCode Oct 24, 2024
4d27541
Remove previous defaults
KatherineInCode Oct 24, 2024
cfb3bcb
Use old versions
KatherineInCode Oct 25, 2024
92db10f
Use actual iOS version we're using for tests
KatherineInCode Oct 25, 2024
08efe26
Update step name
KatherineInCode Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
8000 Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ env:
MINT_LINK_PATH: .mint/bin
MINT_PATH: .mint/lib
RESULT_BUNDLE_PATH: build/BitwardenTests.xcresult
SIMULATOR_NAME: ${{ inputs.simulator-name || 'iPhone 15 Pro' }}
SIMULATOR_VERSION: ${{ inputs.simulator-version || '18.0' }}
SIMULATOR_NAME: ${{ inputs.simulator-name }}
SIMULATOR_VERSION: ${{ inputs.simulator-version }}
XCODE_VERSION: ${{ inputs.xcode-version }}

jobs:
Expand Down Expand Up @@ -69,9 +69,11 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Read default Xcode version
- name: Read default Xcode version and simulator configuration
run: |
echo "DEFAULT_XCODE_VERSION=$(cat .xcode-version | tr -d '\n')" >> "$GITHUB_ENV"
echo "DEFAULT_SIMULATOR_NAME=$(cat .test-simulator-device-name | tr -d '\n')" >> "$GITHUB_ENV"
echo "DEFAULT_SIMULATOR_VERSION=$(cat .test-simulator-ios-version | tr -d '\n')" >> "$GITHUB_ENV"

- name: Set Xcode version
uses: maxim-lobanov/setup-xcode@60606e260d2fc5762a71e64e74b2174e8ea3c8bd # v1.6.0
Expand Down Expand Up @@ -117,7 +119,7 @@ jobs:
-project Bitwarden.xcodeproj \
-scheme Bitwarden \
-configuration Debug \
-destination "platform=iOS Simulator,name=${{ env.SIMULATOR_NAME }},OS=${{ env.SIMULATOR_VERSION }}" \
-destination "platform=iOS Simulator,name=${{ env.SIMULATOR_NAME || env.DEFAULT_SIMULATOR_NAME }},OS=${{ env.SIMULATOR_VERSION || env.DEFAULT_SIMULATOR_VERSION }}" \
-resultBundlePath ${{ env.RESULT_BUNDLE_PATH }} \
-derivedDataPath build/DerivedData \
| xcbeautify --renderer github-actions
Expand Down
1 change: 1 addition & 0 deletions .test-simulator-device-name
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
iPhone 15 Pro
1 change: 1 addition & 0 deletions .test-simulator-ios-version
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
18.0
Loading
0