[PM-11213] Use iPhone 16 Pro test device and finish updating builds for Xcode 16.1 #1096
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1096 +/- ##
==========================================
- Coverage 89.56% 89.34% -0.23%
==========================================
Files 677 677
Lines 42805 42761 -44
==========================================
- Hits 38340 38205 -135
- Misses 4465 4556 +91 ☔ View full report in Codecov by Sentry. |
| @@ -9,10 +9,10 @@ open class BitwardenTestCase: XCTestCase { | |||
|
|
|||
| @MainActor | |||
| override open class func setUp() { | |||
| if UIDevice.current.name != "iPhone 15 Pro" || UIDevice.current.systemVersion != "18.1" { | |||
| if UIDevice.current.name != "iPhone 16 Pro" || UIDevice.current.systemVersion != "18.1" { | |||
There was a problem hiding this comment.
🤔 do you see a lint warning for this when you run locally?
There was a problem hiding this comment.
Weird, spacing got messed up somehow. That should be fixed now.
phil-livefront
previously approved these changes
Oct 31, 2024
fedemkr
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-11213
📔 Objective
Because the macos-15 runner doesn't have an iPhone 15 Pro as an option, we need to update to an iPhone 16 Pro.
As well, in the previous PR, I missed that
CI-main.ymlwas also manually setting the Xcode version, and that has also been updated.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes