PM-14620: Remove unused accessSecretsManager property to fix JSON decoding errors #1116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1115) Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2024.11-rc1 #1116 +/- ##
======================================================
Coverage ? 89.42%
======================================================
Files ? 679
Lines ? 43082
Branches ? 0
======================================================
Hits ? 38528
Misses ? 4554
Partials ? 0 ☔ View full report in Codecov by Sentry. |
fedemkr
approved these changes
Nov 8, 2024
matt-livefront
added a commit
that referenced
this pull request
Nov 11, 2024
…oding errors (backport of #1116)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14620
📔 Objective
Fixes a JSON decoding error in Crashlytics because
accessSecretsManageris missing. I'm guessing this is caused by an older self-hosted instance? But since we don't use this property, I don't see any reason to keep it around.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes