8000 [PM-9375] Initial workflow for building to simulator by KatherineInCode · Pull Request #1144 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-9375] Initial workflow for building to simulator #1144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

KatherineInCode
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9375

📔 Objective

In order to better automate QA testing, we want to be able to load the app into an arbitrary simulator without an attached Xcode. Because building this will take a slightly different flow from our normal build-archive-and-upload flow, it makes sense to do it as a separate workflow. This establishes that, so that it's easier in the future to run while building out this capability.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@KatherineInCode KatherineInCode marked this pull request as ready for review November 15, 2024 17:30
@KatherineInCode KatherineInCode requested a review from a team as a code owner November 15, 2024 17:30
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details9cb054b4-f7bd-486b-98e8-baee5375eec6

No New Or Fixed Issues Found

Copy link
codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.49%. Comparing base (8905534) to head (5377297).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1144   +/-   ##
=======================================
  Coverage   89.48%   89.49%           
=======================================
  Files         687      687           
  Lines       43468    43484   +16     
=======================================
+ Hits        38899    38915   +16     
  Misses       4569     4569           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@KatherineInCode KatherineInCode merged commit bf2b137 into main Nov 18, 2024
9 checks passed
@KatherineInCode KatherineInCode deleted the pm-9375/create-sim-build-flow branch November 18, 2024 15:41
< 6526 div id="partial-timeline" class="js-timeline-marker js-socket-channel js-updatable-content" data-channel="eyJjIjoicHVsbF9yZXF1ZXN0OjIxODIyODgwNTIiLCJ0IjoxNzUwOTA2NzE1fQ==--18e53a725675c5aecd6c7cf5e344fc0149d09a2413479c47e4986056f21376b3" data-url="/bitwarden/ios/pull/1144/partials/unread_timeline?since=2024-11-18T07%3A41%3A04.000000000-08%3A00" data-channel-event-name="timeline_updated" data-last-modified="2024-11-18T07:41:04.000000000-08:00" data-gid="PR_kwDOJ7nh3M6CExK0">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0