PM-13367: Fix TDE logout could bypass MP approval #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1140 +/- ##
==========================================
+ Coverage 89.36% 89.38% +0.01%
==========================================
Files 688 688
Lines 43702 43734 +32
==========================================
+ Hits 39056 39091 +35
+ Misses 4646 4643 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
fedemkr
previously approved these changes
Nov 18, 2024
fedemkr
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-13367
📔 Objective
This fixes a bug where after logging out and then back into an account with TDE and a master password, if you switch accounts on the vault unlock screen you can get into the newly added TDE account without having to confirm your master password.
The root cause of this was that
VaultTimeoutServicewas usingStateService.getAccountIdOrActiveId(_:)to get the active user ID, but this does some validation on the user ID and the user ID was already deleted prior to this. I ended up reversing the order of this so the account is ultimately deleted last. However, this caused an issue with the database publishers getting updates as the user's data is deleted from the database. At that point the vault is locked so if any decryption operations are attempted, it would log an error. Instead of deleting data table-by-table, I updated the batch delete to delete everything before merging the changes back into the context.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes