PM-11469: Hide master password text field if account does not have MP. #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
+ Coverage 89.39% 89.43% +0.04%
==========================================
Files 688 688
Lines 43798 43812 +14
==========================================
+ Hits 39152 39184 +32
+ Misses 4646 4628 -18 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
fedemkr
reviewed
Nov 26, 2024
| let hasMasterPassword = try await services.authRepository.hasMasterPassword() | ||
| state.shouldShowPasswordOrPinFields = hasMasterPassword || state.unlockMethod == .pin | ||
| } catch { | ||
| services.errorReporter.log(error: error) |
There was a problem hiding this comment.
⛏️ Could a test be added for when services.authRepository.hasMasterPassword() throws?
There was a problem hiding this comment.
yeah I can add that, and I will also make sure to do
state.shouldShowPasswordOrPinFields = state.unlockMethod == .pin
in catch block.
fedemkr
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
This update ensures that the master password and PIN text fields are not displayed if the user has not set up a master password or PIN.
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes