8000 PM-15107: Fix JSON decoding errors for ProfileOrganizationResponseModels and ConfigResponseModel by matt-livefront · Pull Request #1162 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PM-15107: Fix JSON decoding errors for ProfileOrganizationResponseModels and ConfigResponseModel #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? 8000 Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2024
Merged

PM-15107: Fix JSON decoding errors for ProfileOrganizationResponseModels and ConfigResponseModel #1162

merged 2 commits into from
Dec 2, 2024

Conversation

matt-livefront
Copy link
Collaborator
@matt-livefront matt-livefront commented Nov 22, 2024 •
edited by jira bot
Loading

🎟️ Tracking

PM-15107

📔 Objective

This fixes the following JSON decoding errors for missing properties:

  • Missing ProfileOrganizationResponseModel.familySponsorshipAvailable
    • I removed the this property and a few others in this model since we aren't using them in the app.
  • Missing ConfigResponseModel.gitHash
    • I made gitHash optional

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@codecov Codecov
Copy link
codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.38%. Comparing base (c564772) to head (ab97620).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1162   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files         688      688           
  Lines       43741    43741           
=======================================
  Hits        39098    39098           
  Misses       4643     4643

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details – 9620da0e-a7bd-48a8-8c60-3a076acc825a

No New Or Fixed Issues Found

fedemkr
fedemkr reviewed Nov 25, 2024
View reviewed changes
Copy link
Member
@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Are we sure in ProfileOrganizationResponse that we're not using useKeyConnector and useTotp? We may be using these from other places but I thought the profile org response was updating another part of the app somehow, but surely I incorrectly recall it.

@matt-livefront
Copy link
Collaborator Author

🤔 Are we sure in ProfileOrganizationResponse that we're not using useKeyConnector and useTotp? We may be using these from other places but I thought the profile org response was updating another part of the app somehow, but surely I incorrectly recall it.

@fedemkr Good question. If we were using these, I think we'd run into compilation issues. I double checked and I don't think we are.

  • useTotp: We use Cipher.organizationUseTotp, but I don't see us using this from ProfileOrganizationResponse.
  • useKeyConnector: We use Profile.usesKeyConnector and Organization.keyConnectorUrl to check for key connector, but I don't see us using useKeyConnector.

@matt-livefront matt-livefront merged commit efbb735 into main Dec 2, 2024
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-15107-family-sponsorship-properties branch December 2, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedemkr fedemkr fedemkr left review comments

@KatherineInCode KatherineInCode KatherineInCode approved these changes

@ezimet-livefront ezimet-livefront Awaiting requested review from ezimet-livefront

@phil-livefront phil-livefront Awaiting requested review from phil-livefront

@brant-livefront brant-livefront Awaiting requested review from brant-livefront

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matt-livefront @fedemkr @KatherineInCode
0