8000 PM-11494: fixed session timeout not being respected when switch account by ezimet-livefront · Pull Request #1174 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PM-11494: fixed session timeout not being respected when switch account #1174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 10, 2024

Conversation

ezimet-livefront
Copy link
Collaborator
@ezimet-livefront ezimet-livefront commented Nov 27, 2024

🎟️ Tracking

PM-11494

📔 Objective

This update addresses the issue where session timeouts are not recorded when a user switches accounts.

  • The lastActiveTime is now recorded whenever a user switches to a different account.
  • A session timeout verification is performed before displaying the profile switcher.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 97.72727% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.40%. Comparing base (8293f41) to head (9a03afd).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...Shared/Core/Auth/Repositories/AuthRepository.swift 96.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1174   +/-   ##
=======================================
  Coverage   89.39%   89.40%           
=======================================
  Files         688      688           
  Lines       43798    43812   +14     
=======================================
+ Hits        39152    39168   +16     
+ Misses       4646     4644    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor
github-actions bot commented Nov 27, 2024

Logo
Checkmarx One – Scan Summary & Details59cf54cc-e9a8-420f-83fc-49865689d1c3

Fixed Issues

Severity Issue Source File / Package
LOW Unpinned Actions Full Length Commit SHA /crowdin-push.yml: 26

@ezimet-livefront ezimet-livefront merged commit 375fa3b into main Dec 10, 2024
9 checks passed
@ezimet-livefront ezimet-livefront deleted the PM-11494/session-timeout branch December 10, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0