[PM-15905] feat: Restructure build info output #1193
Conversation
|
No New Or Fixed Issues Found |
…now include the run attempt
|
🤔 It does look like the new version won't have some information, and require tapping through to view the run itself on device. Would it be valuable to do both, have a link to the run and still provide all that information for a quick glance? |
We discussed this in private, it should convey the same information with the exception of CI Run Number. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1193 +/- ##
=======================================
Coverage 89.49% 89.49%
=======================================
Files 688 688
Lines 43833 43840 +7
=======================================
+ Hits 39229 39236 +7
Misses 4604 4604 ☔ View full report in Codecov by Sentry. |
| @@ -4,5 +4,5 @@ | |||
| /// | |||
| enum CIBuildInfo { | |||
| /// Dictionary containing the info generated by the CI process. | |||
| static let info: [String: String] = [:] | |||
| static let info: KeyValuePairs<String, String> = [:] | |||
There was a problem hiding this comment.
🤔 I guess we do actually want these in a consistent order each time, huh.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15905
📔 Objective
Restructure build info output copied from our About view, to reduce vertical space while providing the necessary info required for our team to troubleshoot. All information was retained except CI Run Number, which we can get by navigating to the build source. Compiler flags line is removed if empty and while at it, added the build variant.
New structure:
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes