PM-15375: show App review prompt. #1207
Conversation
…, added eligibility check in state services, added unit tests
| @@ -345,6 +346,20 @@ struct VaultListView: View { | |||
| .task(id: store.state.vaultFilterType) { | |||
| await store.perform(.streamVaultList) | |||
| } | |||
| .task(id: store.state.isEligibleForAppReview) { | |||
| if store.state.isEligibleForAppReview { | |||
| SKStoreReviewController.requestReview() | |||
There was a problem hiding this comment.
we can replace this with this new api, when we bump the version to iOS 16.
@Environment(\.requestReview) var requestReview
requestReview()
There was a problem hiding this comment.
🤔 Is there a way we could use a #avaialble check here to use the controller vs the environment approach one? Because SKStoreReviewController has been deprecated in iOS 18.
There was a problem hiding this comment.
this has been updated.
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1207 +/- ##
==========================================
- Coverage 89.42% 89.41% -0.01%
==========================================
Files 692 692
Lines 43995 44059 +64
==========================================
+ Hits 39343 39396 +53
- Misses 4652 4663 +11 ☔ View full report in Codecov by Sentry. |
🎟️ Tracking
PM-15375
PM-15377
PM-15415
PM-15531
📔 Objective
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes