[PM-8216] Add Change Email and Set Up Two-Factor URLs #1210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1210 +/- ##
==========================================
+ Coverage 89.42% 89.44% +0.01%
==========================================
Files 692 692
Lines 43995 44009 +14
==========================================
+ Hits 39343 39363 +20
+ Misses 4652 4646 -6 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
fedemkr
approved these changes
Dec 16, 2024
|
I think another PR makes sense, just to reduce the noise 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8216
📔 Objective
This adds additional URLs to the Environment Service, Environment URLs, and Environment URL Data objects for 1) changing email (which is currently just the account screen) and 2) setting up two-factor authentication. These will be used by new screens in the future.
This also adds new tests to backfill some gaps in our test coverage.
This also does a bit of minor refactoring to unify casing structure inside each of these classes to follow the Swift API Design Guidelines, which suggests that "URL" should be capitalized inside of properties and function names. Ideally we would also change
EnvironmentUrlsandEnvironmentUrlDatatoEnvironmentURLsandEnvironmentURLDatafor this as well, but I wasn't sure if that was too big a change for this PR. If sentiment is towards ripping that bandaid off now, I can do that additionally.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes