8000 [PM-16211] chore(ci): Fix hotfix branch creation workflow by retrieving the last tag across all branches by vvolkgang · Pull Request #1220 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-16211] chore(ci): Fix hotfix branch creation workflow by retrieving the last tag across all branches #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

8000 By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

vvolkgang
Copy link
Member

🎟️ Tracking

PM-16211

📔 Objective

The previous method to retrieve the last release git tag only worked when all tags are in the main branch. We'll now get the last tag across all branches.

While at it removed the rc prefix input which won't be used in this repo.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@vvolkgang vvolkgang requested a review from a team as a code owner December 18, 2024 23:53
@vvolkgang vvolkgang enabled auto-merge (squash) December 18, 2024 23:54
@vvolkgang vvolkgang merged commit bff1bcb into main Dec 19, 2024
7 checks passed
@vvolkgang vvolkgang deleted the fix-release-branch branch December 19, 2024 00:05
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb03964db-9b4d-4b21-af88-f52c5d5dc27d

No New Or Fixed Issues Found

Copy link
codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.51%. Comparing base (625bbd3) to head (c789ace).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
+ Coverage   89.43%   89.51%   +0.07%     
==========================================
  Files         692      699       +7     
  Lines       44080    44556     +476     
==========================================
+ Hits        39423    39884     +461     
- Misses       4657     4672      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0