[QA-963] Adding/Updating automationIDs on Login/CreateAccount/SSOLogin views #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No New Or Fixed Issues Found |
matt-livefront
approved these changes
Jan 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1255 +/- ##
=======================================
Coverage 89.42% 89.43%
=======================================
Files 725 725
Lines 45808 45811 +3
=======================================
+ Hits 40966 40969 +3
Misses 4842 4842 ☔ View full report in Codecov by Sentry. |
fedemkr
reviewed
Jan 13, 2025
| @@ -40,7 +40,8 @@ struct SingleSignOnView: View { | |||
| text: store.binding( | |||
| get: \.identifierText, | |||
| send: SingleSignOnAction.identifierTextChanged | |||
| ) | |||
| ), | |||
| accessibilityIdentifier: "SSOOrgIdField" | |||
There was a problem hiding this comment.
🤔 @ifernandezdiaz I believe this should have Entry instead of Field as a suffix => SSOOrgIdEntry to keep it consistent to how we use it elsewhere, e.g. in this PR LoginEmailAddressEntry, LoginMasterPasswordEntry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
📔 Objective
This work is a subtask of QA-947, a story created to group all the native app views that contain elements without Automation IDs.
NOTE: Not all the elements will require an AutomationID. We are adding the ones we currently need so we can reduce the flakiness on some critical Mobile e2e tests
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes