[PM-17467] 🍒 Wrapped Credential Exchange related APIs into SUPPORTS_CXP compiler flag (#1295) #1296
+55
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to not have issues with Apple changing them and crashing the app. Also added an additional config so compiler flags are available in the shared tests target.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/2025.01-rc4 #1296 +/- ##
=======================================================
+ Coverage 89.42% 89.60% +0.18%
=======================================================
Files 724 724
Lines 45796 45676 -120
=======================================================
- Hits 40954 40930 -24
+ Misses 4842 4746 -96 ☔ View full report in Codecov by Sentry. |
KatherineInCode
approved these changes
Jan 23, 2025
|
New Issues (1)Checkmarx found the following issues in this Pull Request
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-17467
📔 Objective
Cherry pick of #1295 but targeting release branch.
Wrap all Credential Exchange related APIs into the compiler flag
SUPPORTS_CXPso those symbols are not added to the final IPA until Apple has the final version of the APIs. If we don't wrap them, then if Apple decides to do a breaking change in those APIs it could lead to a crash in the app.Additionally, configs files were added and
project-pm.ymlhas been updated so BitwardenSharedTests target can also haveSWIFT_ACTIVE_COMPILATION_CONDITIONSavailable automatically depending on what's being set on the config.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes