8000 PM-17413: Update policy banner design by matt-livefront · Pull Request #1303 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

PM-17413: Update policy banner design #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

matt-livefront
Copy link
Collaborator
@matt-livefront matt-livefront commented Jan 27, 2025

🎟️ Tracking

PM-17413

📔 Objective

Updates the design of the info container used for showing policy information.

Note: the dark mode color of backgroundTertiary wasn't correct, so there's a few snapshot updates for the action card which also used this background.

📸 Screenshots

Before After
Screenshot 2025-01-27 at 2 23 30 PM Screenshot 2025-01-27 at 2 19 37 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link
codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.46%. Comparing base (497a0f9) to head (e0e960d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...Auth/SetMasterPassword/SetMasterPasswordView.swift 50.00% 1 Missing ⚠️
.../UI/Platform/Application/Views/InfoContainer.swift 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
- Coverage   89.47%   89.46%   -0.01%     
==========================================
  Files         740      743       +3     
  Lines       46431    46580     +149     
==========================================
+ Hits        41544    41674     +130     
- Misses       4887     4906      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor
github-actions bot commented Jan 27, 2025

Logo
Checkmarx One – Scan Summary & Detailsd1f48bc2-377c-4f73-8301-bbf931c88efd

Great job, no security vulnerabilities found in this Pull Request

Copy link
Member
@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however since we're here. Do you know why some policy banners are middle aligned and other left aligned? Should we be consistent on that?
e.g. here

@matt-livefront
Copy link
Collaborator Author

LGTM, however since we're here. Do you know why some policy banners are middle aligned and other left aligned? Should we be consistent on that? e.g. here

Good question! I don't think we have designs for all of the places where we have these, so I think I matched the alignment that existed in MAUI when originally implementing these. I spoke with design through and they recommended left-alignment so I'll update this.

@matt-livefront matt-livefront merged commit b158e94 into main Jan 28, 2025
9 checks passed
@matt-livefront matt-livefront deleted the matt/PM-17413-policy-banners branch January 28, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0