-
Notifications
You must be signed in to change notification settings - Fork 53
PM-17413: Update policy banner design #1303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1303 +/- ##
==========================================
- Coverage 89.47% 89.46% -0.01%
==========================================
Files 740 743 +3
Lines 46431 46580 +149
==========================================
+ Hits 41544 41674 +130
- Misses 4887 4906 +19 ☔ View full report in Codecov by Sentry. |
Great job, no security vulnerabilities found in this Pull Request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, however since we're here. Do you know why some policy banners are middle aligned and other left aligned? Should we be consistent on that?
e.g. here
Good question! I don't think we have designs for all of the places where we have these, so I think I matched the alignment that existed in MAUI when originally implementing these. I spoke with design through and they recommended left-alignment so I'll update this. |
🎟️ Tracking
PM-17413
📔 Objective
Updates the design of the info container used for showing policy information.
Note: the dark mode color of
backgroundTertiary
wasn't correct, so there's a few snapshot updates for the action card which also used this background.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes