8000 [PM-17914] Show connect to watch toggle only on iPhone by infinitepower18 · Pull Request #1317 · bitwarden/ios · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[PM-17914] Show connect to watch toggle only on iPhone #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Feb 26, 2025
Merged

[PM-17914] Show connect to watch toggle only on iPhone #1317

merged 13 commits into from
Feb 26, 2025

Conversation

infinitepower18
Copy link
Contributor

📔 Objective

The connect to watch toggle is now only shown if the app is run on iPhone. There is no use showing the toggle on iPad and iPod touch as those devices can't be paired to an Apple Watch.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

fedemkr
fedemkr reviewed Feb 3, 2025
View reviewed changes
Copy link
Member
@fedemkr fedemkr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, great catch! Thank you for your contribution and here I leave you some improvements to make in order to be consistent on how we implement this kind of logic in the app.
If you have any questions, let me know 😄

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-17914

@bitwarden-bot bitwarden-bot changed the title Show connect to watch toggle only on iPhone [PM-17914] Show connect to watch toggle only on iPhone Feb 3, 2025
fedemkr
fedemkr reviewed Feb 6, 2025
View reviewed changes
Copy link
Member
@fedemkr fedemkr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great thanks for the improvements, just a few more to complete it.

@fedemkr fedemkr self-assigned this Feb 7, 2025
@CLAassistant
Copy link
CLAassistant commented Feb 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ infinitepower18
❌ fedemkr
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Feb 7, 2025 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 9a1015ef-1462-4146-93bb-c9cccdff2794

Great job, no security vulnerabilities found in this Pull Request

@codecov Codecov
Copy link
codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.63%. Comparing base (3fc1bd4) to head (836a153).
Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
...nShared/Core/Platform/Utilities/SystemDevice.swift 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1317      +/-   ##
==========================================
- Coverage   89.63%   89.63%   -0.01%     
==========================================
  Files         751      751              
  Lines       47138    47145       +7     
==========================================
+ Hits        42253    42257       +4     
- Misses       4885     4888       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fedemkr
Copy link
Member
fedemkr commented Feb 18, 2025

Hi @infinitepower18 this PR has been approved and moved to QA for testing. Thank you so much for your contribution!

@fedemkr
Copy link
Member
fedemkr commented Feb 25, 2025

Hi @infinitepower18 , QA tested this and even though it works on most cases the toggle is still shown when the device is iPod. So I was thinking we could just check WCSession.default.isSupported which would be a more general solution for any device given that it will actually check if the device supports a watch session instead of changing which device you're on.
Would you like to do the change? Otherwise I can take of it. Thanks again for your contribution!

@infinitepower18
Copy link
Contributor Author

Hi @fedemkr, do you mind if you do the change? Thanks

@fedemkr
Copy link
Member
fedemkr commented Feb 26, 2025

Hi @infinitepower18 sure thing I'll fix that and again thank you so much for your contribution! 😄

@fedemkr fedemkr changed the base branch from main to PM-17914/connect-to-watch-only-available February 26, 2025 20:20
@fedemkr fedemkr merged commit 2928015 into bitwarden:PM-17914/connect-to-watch-only-available Feb 26, 2025
4 checks passed
fedemkr added a commit that referenced this pull request Feb 27, 2025
@fedemkr @infinitepower18
[PM-17914] Show connect to watch only when available by @infinitepower18
60d614c 
 in #1317 (#1391)

Co-authored-by: Ahnaf Mahmud <44692189+infinitepower18@users.noreply.github.com>
@fedemkr
Copy link
Member
fedemkr commented Mar 13, 2025

Hi @infinitepower18 wanted to let you know that I did the changes (#1391) and this has already passed QA testing and has been merged to main. So it's going to be available in one of the next releases. Thank you again for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fedemkr fedemkr fedemkr approved these changes

@matt-livefront matt-livefront Awaiting requested review from matt-livefront

@phil-livefront phil-livefront Awaiting requested review from phil-livefront

@brant-livefront brant-livefront Awaiting requested review from brant-livefront

@ezimet-livefront ezimet-livefront Awaiting requested review from ezimet-livefront

Assignees

@fedemkr fedemkr

Labels
community-pr needs-qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@infinitepower18 @bitwarden-bot @CLAassistant @fedemkr
0